Properly initialize Configuration.interceptors when using old-style APIs.
#297
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
By analyzing the blame information on this pull request, we identified @richardjrossiii, @grantland and @wangmengyan95 to be potential reviewers. |
Contributor
|
Can we Also, it seems like we should be clearing or nullifying |
… APIs. This happened because `this.interceptors` was null when `clear()` was invoked. Fixes #296.
richardjrossiii
force-pushed
the
richardross.npe.fix
branch
from
db9264f to
210c913
Compare
|
@richardjrossiii updated the pull request. |
facebook-github-bot
added
GH Review: review-needed
and removed
GH Review: needs-revision
labels
Contributor
|
LGTM |
richardjrossiii
added a commit
that referenced
this pull request
Dec 15, 2015
Properly initialize `Configuration.interceptors` when using old-style APIs.
|
@richardjrossiii updated the pull request. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This happened because
this.interceptorswas null whenclear()was invoked.Fixes #296.